Ticket #832 (closed defect: fixed)

Opened 17 months ago

Last modified 9 months ago

Invalid getSelect() method in TabSheet.SelectedTabChangeEvent

Reported by: Marko Gronroos Owned by: Jani Laakso
Priority: undefined Milestone: User Interface Library 5.2.0 RC
Component: Server-side framework Version: 4.0.2
Keywords: Cc:
Known Issue description:
Hours estimate: Deadline (dd.mm.yyyy):
Known Issue version (since): Known Issue title:
Hours done: Depends to:
Affects documentation: no
Known Issue workaround:
Affects release notes: yes Contract:

Description

The TabSheet?.SelectedTabChangeEvent? class has a getSelect() method that returns the source component of the event casted to Select class. The source component is always a TabSheet?, which does not inherit the Select class. The cast would therefore always result in an error.

Perhaps the method should be replaced with a getTabSheet() method that returns the source tabsheet?

Change History

Changed 12 months ago by Joonas Lehtinen

  • milestone set to User Interface Library 5.1.0 RC

Changed 11 months ago by Joonas Lehtinen

  • priority changed from minor to undefined

Changed 11 months ago by Marc Englund

  • status changed from new to closed
  • resolution set to fixed

Fixed in [3911]

Changed 11 months ago by Joonas Lehtinen

API change ok. Just fixing a typo.

(Unfortunately this may cause problems for users, but they are trivial to detect and resolve)

Changed 11 months ago by Marc Englund

Just to clarify: AFAIK should not cause problems for users, since the function was impossible to use (getSource() always returned a TabSheet?, which can not be cast to Select -> function can not return Select): 

public Select getSelect() { 
 return (Select) getSource();
}

Changed 9 months ago by Joonas Lehtinen

  • milestone changed from User Interface Library 5.1.2 to User Interface Library 5.2.0

Milestone User Interface Library 5.1.2 deleted

Note: See TracTickets for help on using tickets.