Ticket #523 (new defect)

Opened 22 months ago

Last modified 8 months ago

QueryContainer: refactor implementation

Reported by: Marc Englund Owned by: Jani Laakso
Priority: minor Milestone: IT Mill Sponsored Backlog
Component: Server-side framework Version: 5.0.0
Keywords: Cc:
Known Issue description:
Hours estimate: Deadline (dd.mm.yyyy):
Known Issue version (since): Known Issue title:
Hours done: Depends to:
Affects documentation: no
Known Issue workaround:
Affects release notes: no Contract:

Description

-removed- notes that the exception in QueryContainer?.getContainerProperty(Object itemId, Object propertyId) is not being logged or thrown - failing silently. 

try {
  result.absolute(((Integer) itemId).intValue());
  value = result.getObject((String) propertyId);
} catch (Exception e) {
  return null;
}

Change History

Changed 22 months ago by Jani Laakso

  • summary changed from QueryContainer, exception handling to QueryContainer: refactor implementation

There's also other issues that -removed- has reported. Whole class has been done in a hurry when comparing to other Toolkit classes, it does not show good quality currently.

Another -removed-'s good point: statement should be closed as soon it's no longer used, see refresh()

Jani's comments: There's bunch of arg0, arg1 used, replace them with better descriptive names.

Changed 15 months ago by Jani Laakso

  • milestone deleted

Milestone 4.0 Candidates for next release deleted

Changed 10 months ago by Jani Laakso

  • version changed from 4.0.0-rc to 5.0.0
  • affects_release_notes unset

Changed 8 months ago by Joonas Lehtinen

  • milestone set to IT Mill Sponsored Backlog
Note: See TracTickets for help on using tickets.