Widgetset creation is very error prone

[Mauno Haukila]

Widget creation is very easy but widgetSET creation is not. You have to define xml, no verification on right syntax, very error prone.

I had a little situation recently where hosted mode browser crashed and firefox complained about javascript taking too long. I double checked syntax for package\gwt\mywidgetset.gwt.xml and widgetset-class and I found no errors on quick look. Widgetset compiled successfully.

I noticed that if I added "?debug" parameter to URL, Toolkit debug window had text "too much javascript recursion".

Problem was one typo in createWidget method.

if ("com.itmill.toolkit.training.chaptr8.gwt.client.ui.INumbersOnlyTextField"
                .equals(className)) {
            return new INumbersOnlyTextField();
        }

Should have been:

if ("com.itmill.toolkit.training.chapter8.gwt.client.ui.INumbersOnlyTextField"
                .equals(className)) {
            return new INumbersOnlyTextField();
        }

[Joonas Lehtinen]

I hope this will be resolved when we add a "create widgetset" wizard to IDE integration. See #98

Closing this as a duplicate for now. Please reopen i you have have any intermediate solutions before that.

[Mauno Haukila]

Checked out current trunk and tested:

        final String className = resolveWidgetTypeName(uidl);        
        if (ICheckBox.class.getName().equals(className)) {
            return new ICheckBox();
        } else if (IButton.class.getName()
                .equals(className)) {
            return new IButton();
        } else if (IWindow.class.getName()
                .equals(className)) {
            return new IWindow();

Seems to work fine.

[Matti Tahvonen]

in [5884] refactored DefaultWidgetSet? to use class comparison instead of class name. (now possible with GWT 1.5, changed the version to trunk). So there is actually no need to do string comparison at all nowadays. Change should be backwards compatible. There was actually a TODO for this in Default widget set.

Other widgetsets and manual should be updated. Assigning to Marko

[Joonas Lehtinen]

Matti - does this close the ticket?

As this is only for GWT 1.5, I'll move the ticket to 5.3.0

[Matti Tahvonen]

When manual and examples are updated.

[Matti Tahvonen]

Changed ReservationWidgetSet? and ColorPickerWidgetSet? to use the new method in [5957].

Magi check those as an example and update manual to correspond the new system.

[Marko Gronroos]

Reformatted the examples to be more suitable for the manual in [5988]. Updated the manual according to the updated examples in [5987].