Ticket #2185 (closed defect: fixed)

Opened 2 months ago

Last modified 3 weeks ago

web.xml includes junk - must be cleaned

Reported by: Joonas Lehtinen Owned by: Joonas Lehtinen
Priority: minor Milestone: User Interface Library 5.3.0 RC4
Component: Demos Version: 5.2.11
Keywords: Cc:
Known Issue description:
Hours estimate: Deadline (dd.mm.yyyy):
Known Issue version (since): Known Issue title:
Hours done: Depends to:
Affects documentation: no
Known Issue workaround:
Affects release notes: no Contract:

Description (last modified by Joonas Lehtinen) (diff)

Now web.xml contains all kinds of unnecessary junk that has no relation to the product. Please remove everything that does not ship with the product and is needed for the product to function.

For an example, see [5757]

Change History

Changed 2 months ago by Joonas Lehtinen

  • description modified (diff)

Changed 6 weeks ago by Joonas Lehtinen

  • milestone changed from User Interface Library 5 stable branch backlog to User Interface Library 5.3.0 RC2

Changed 4 weeks ago by Joonas Lehtinen

  • milestone changed from User Interface Library 5.3.0 RC4 to IT Mill Sponsored Backlog

Changed 3 weeks ago by Joonas Lehtinen

  • owner changed from ticketmaster to Joonas Lehtinen
  • status changed from new to accepted
  • milestone changed from IT Mill Sponsored Backlog to User Interface Library 5.3.0 RC4

Changed 3 weeks ago by Joonas Lehtinen

  • status changed from accepted to closed
  • resolution set to fixed

Fixed in [6237]

Also removed all tests that are not supposed to be used by the user who loads the package. Tests should be run from another web.xml or through app runner.

Also extensively commented the web.xml

Changed 3 weeks ago by Matti Tahvonen

  • status changed from closed to reopened
  • resolution deleted

Hi!

I think you accidentally cleaned the wrong web.xml file. The one that goes into "testers package" and war lives in build/package/WebContent/WEB-INF/web.xml. That one ought to be cleaned and documented.

The one in trunk/WebContent/WEB-INF/web.xml is devoted for framework developers and it is essential that it has all possible test apps available without extra xml hacking. This XML file is just the right place for them. TestBench?, FeaturesApplication? (the very old FB) etc are important test applications and they need to be quickly available when developer starts hacking with core framework.

Changed 3 weeks ago by Marc Englund

Copied the changes to build/package/web.xml in [6244]

Changed 3 weeks ago by Marc Englund

  • status changed from reopened to closed
  • resolution set to fixed

Reverted to old "development" web.xml in [6245] - for now, we should probably clean the development version as well, and make it as close to the package one as possible, but this is not important - added ticket #2361 for that.

Changed 3 weeks ago by Joonas Lehtinen

Marc, thanks. My mistake.

Note: See TracTickets for help on using tickets.