Form.discard() should clear the error message from the form

[Joonas Lehtinen]

Now the error messahe is show in the form only after commit(). It would be intuitive to clear the error message when doing discard().

[Joonas Lehtinen]

Testcase missing.

[Joonas Lehtinen]

Test-case:

import com.itmill.toolkit.Application;
import com.itmill.toolkit.data.Item;
import com.itmill.toolkit.data.util.BeanItem;
import com.itmill.toolkit.data.validator.StringLengthValidator;
import com.itmill.toolkit.ui.Button;
import com.itmill.toolkit.ui.Form;
import com.itmill.toolkit.ui.HorizontalLayout;
import com.itmill.toolkit.ui.Window;
import com.itmill.toolkit.ui.Button.ClickEvent;

public class TestApp extends Application {

	public void init() {
		final Window main = new Window("Testing....");
		setMainWindow(main);

		final Name name = new Name();
		Form f = new Form();
		Item i = new BeanItem(name);

		f.setCaption("Test form");
		f.setItemDataSource(i);
		f.setWriteThrough(false);
		f.setReadThrough(false);

		HorizontalLayout buttons = new HorizontalLayout();
		buttons.addComponent(new Button("Commit", f, "commit"));
		buttons.addComponent(new Button("Discard", f, "discard"));
		f.setFooter(buttons);

		f.getField("firstName").addValidator(
				new StringLengthValidator("Must be at least 3 characters", 3,
						1000, false));

		main.addComponent(f);

		main.addComponent(new Button("Show datasource contents",
				new Button.ClickListener() {

					public void buttonClick(ClickEvent event) {
						main.showNotification(name.firstName + "<br/>"
								+ name.lastName);
					}
				}));
	}

	public class Name {
		String firstName="";
		String lastName="";

		public String getFirstName() {
			return firstName;
		}

		public void setFirstName(String firstName) {
			this.firstName = firstName;
		}

		public String getLastName() {
			return lastName;
		}

		public void setLastName(String lastName) {
			this.lastName = lastName;
		}

	}
}

[Joonas Lehtinen]

Could not reproduce the issue.