Ticket #2053 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Closing browse-window should trigger submitting changes and fire close-event

Reported by: Joonas Lehtinen Owned by: Joonas Lehtinen
Priority: major Milestone: User Interface Library 5.2.7
Component: gwt-adapter-client Version: 5.2.5
Keywords: Cc: matti.tahvonen@…, johannes.tuikkala@…
Known Issue description:
Hours estimate: Deadline (dd.mm.yyyy):
Known Issue version (since): Known Issue title:
Hours done: Depends to:
Affects documentation: no
Known Issue workaround:
Affects release notes: no Contract:

Description

Now when a browser-window is closed, non-immediate changes made are lost. Also the window close() is not properly called.

Change History

Changed 4 months ago by Joonas Lehtinen

  • status changed from new to accepted

Changed 4 months ago by Joonas Lehtinen

Wrote a test [5350]

Changed 4 months ago by Joonas Lehtinen

  • status changed from accepted to closed
  • resolution set to fixed

Fixed in [5351]

Changed 4 months ago by Joonas Lehtinen

More fixes in [5353] and [5354]

Changed 4 months ago by Jouni Koivuviita

Should this be backported to 5.2.7? Are there any possible complications if we decide to do so?

Changed 4 months ago by Matti Tahvonen

  • status changed from closed to reopened
  • resolution deleted

No, current fixes are incomplete. Joonas is still working on this.

Changed 4 months ago by Joonas Lehtinen

  • status changed from reopened to accepted

Changed 4 months ago by Joonas Lehtinen

This work is also basis for #1970 that is requested to be included in 5.2. Unfortunately this will not be ready for 5.2.7.

Changed 4 months ago by Joonas Lehtinen

Just for the bookkeeping: the missing part of the fix is to guarantee that all waiting variablechanges are are sent together with the closing variablechanges. And furthermore guarantee that they are executed in proper order.

Changed 4 months ago by Joonas Lehtinen

  • cc matti.tahvonen@… added
  • status changed from accepted to closed
  • resolution set to fixed
  • milestone changed from User Interface Library 5.3.0 RC to User Interface Library 5.2.7

Fixed in [5419]

Matti, please review this commit as you are the original author of variable change bursting code.

Changed 4 months ago by Matti Tahvonen

  • status changed from closed to reopened
  • resolution deleted

connection field in IView is not necessary defined -> causes npe's in reloaded too fast -> no information to server about window close. Happen often if slow network/computer and reloading or moving away before toolkit app properly started.

Proposed solution: give ApplicationConnection? instance in constructor for iview.

Will, review [5419] asap. Fighting with critical FF initialization issues atm.

Changed 4 months ago by Joonas Lehtinen

  • status changed from reopened to closed
  • resolution set to fixed

Matti, thanks for npe hint. Fixed in [5425].

Changed 4 months ago by Joonas Lehtinen

  • cc johannes.tuikkala@… added
  • status changed from closed to reopened
  • resolution deleted

Window.close default behavior invalidly disabled main-level windows.

Changed 4 months ago by Joonas Lehtinen

  • status changed from reopened to closed
  • resolution set to fixed

Actually the imlementation was ok (and re-open unnecessary)

Note: See TracTickets for help on using tickets.