Ticket #1422 (closed defect: fixed)

Opened 9 months ago

Last modified 7 months ago

ApplicationServlet: Tries to close application when session is expired, code is never reached

Reported by: Jani Laakso Owned by: Joonas Lehtinen
Priority: undefined Milestone: User Interface Library 5.2.0 RC
Component: Server-side framework Version: 4.1.0
Keywords: Cc:
Known Issue description:
Hours estimate: Deadline (dd.mm.yyyy):
Known Issue version (since): Known Issue title:
Hours done: Depends to:
Affects documentation: no
Known Issue workaround:
Affects release notes: yes Contract:

Description

Remove

	private static HashMap applicationToLastRequestDate = new HashMap();

And other related code, such as below:

This code is never run, because Session expiration is handled by Servlet Container, not Toolkit applicaiton itself.

					// Session expiration
					Date lastRequest;
					synchronized (applicationToLastRequestDate) {
						lastRequest = (Date) applicationToLastRequestDate
								.get(application);
					}
					if (lastRequest != null
							&& lastRequest.getTime()
									+ request.getSession()
											.getMaxInactiveInterval() * 1000 < System
									.currentTimeMillis()) {

						// Session expired, close application
						application.close();
					} 

Change History

Changed 9 months ago by Joonas Lehtinen

  • milestone set to User Interface Library 5.1.1

Is this only relevant for 4 or for 5 also?

Changed 9 months ago by Jani Laakso

  • status changed from new to closed
  • resolution set to fixed

Version states 4. I've removed these from TK5.

Some weeks ago I noticed that TK4 still has these but I decided to let them be as no memory leak occurs, it's obsolete code though.

Closing this bug as it's only TK4.

Changed 7 months ago by Joonas Lehtinen

  • milestone changed from User Interface Library 5.1.2 to User Interface Library 5.2.0

Milestone User Interface Library 5.1.2 deleted

Note: See TracTickets for help on using tickets.