Table fires false ValueChangeEvents when contained properties are changed

[Matti Tahvonen]

Table's valueChange(Property.ValueChangeEvent? event) function overrides the one in select. It is there to fire repaint when container property has changed (in action it is a column in table). The one in select notifies listeners that are interested in changes in selection and receive excessive amount of false value changes.

valueChange method should check if source is table itself or from container.

Tree and Select has similar problem.

Joonas, please review the becoming change.

[Matti Tahvonen]

Test case code:

        final Window main = new Window("Hello window");
        setMainWindow(main);

        final Table t = TestForTablesInitialColumnWidthLogicRendering
                .getTestTable(3, 3);

        t.setSelectable(true);

        t.addListener(new Table.ValueChangeListener() {
            public void valueChange(ValueChangeEvent event) {
                System.out.println("Value change");
                System.out.println(event.getProperty().getClass().toString());

            }
        });

        main.addComponent(t);

        main
                .addComponent(new Button(
                        "change (should update table content, but not fire value change from table)",
                        new ClickListener() {
                            public void buttonClick(ClickEvent event) {
                                IndexedContainer c = (IndexedContainer) t
                                        .getContainerDataSource();
                                Item i = c.getItem(c.getIdByIndex(0));
                                Iterator it = i.getItemPropertyIds().iterator();
                                it.next();
                                Object id = it.next();
                                i.getItemProperty(id).setValue("muutos");
                            }
                        }));

        main.addComponent(new Button("select first", new ClickListener() {
            public void buttonClick(ClickEvent event) {
                IndexedContainer c = (IndexedContainer) t
                        .getContainerDataSource();
                t.select(c.getIdByIndex(0));
                // t.setValue(c.getIdByIndex(0));
            }
        }));

        main.addComponent(new Button("restart", new ClickListener() {
            public void buttonClick(ClickEvent event) {
                close();
            }
        }));

[Matti Tahvonen]

fixed in [3664], joonas please review

[Matti Tahvonen]

not only fixed for table