Table column reordering

[Henri Kerola]

Reordering table's columns by drag-and-drop fails when Column property id is not a String.

Problem is in Table's changeVariables method (line 1354) which throws java.lang.ArrayStoreException?:

      if (this.isColumnReorderingAllowed()) {
           if (variables.containsKey("columnorder")) {
               try {
                   Object[] ids = (Object[]) variables.get("columnorder");
                   for (int i = 0; i < ids.length; i++) {
                	   ids[i] = columnIdMap.get(ids[i].toString()); // Throws java.lang.ArrayStoreException
                   }
                   this.setColumnOrder(ids);
               } catch (Exception ignored) {
               }
           }
       }

For example the following code fixes the problem:

if (this.isColumnReorderingAllowed()) {
           if (variables.containsKey("columnorder")) {
               try {
                   Object[] ids = (Object[]) variables.get("columnorder");
                   LinkedList newVC = new LinkedList();
                   for (int i = 0; i < ids.length; i++) {
                	   //ids[i] = columnIdMap.get(ids[i].toString());
                	   newVC.add(columnIdMap.get(ids[i].toString()));
                   }
                   //this.setColumnOrder(ids);
                   this.setColumnOrder(newVC.toArray());
               } catch (Exception ignored) {
               }
           }
       }

[Jani Laakso]

This happens because our code implicitly creates String array, afterward we try to push non String objects (e.g. Integer objects) into it => exception occurs. I'll fix this..

[Jani Laakso]

Fixed in [2883]