Packaging: Upgrade test: Workhours TK4->TK5

[Jani Laakso]

Following issues need to be resolved.

Removed existing Toolkit libraries, themes. Added only itmill-toolkit-5.0.0-alpha.jar under webapp/WEB-INF/lib.

Issue: "Blank screen on startup with Browser, client-side code is missing." FIX: WebContent?/ITMILL needes to be copied manually (or generate through GWTCompiler)

Issue: "class not found exception on startup, servlet-class has changed." FIX: web.xml needs to be updated because servlet-class has changed, use <servlet-class>com.itmill.toolkit.terminal.gwt.server.ApplicationServlet?</servlet-class>

Issue: fileupload jar is missing javax.servlet.ServletException?: java.lang.NoClassDefFoundError?: org/apache/commons/fileupload/servlet/ServletFileUpload

com.itmill.toolkit.terminal.gwt.server.ApplicationServlet?.service(ApplicationServlet?.java:390) javax.servlet.http.HttpServlet?.service(HttpServlet?.java:803)

FIX: Add commons-fileupload-1.2.jar webapp/WEB-INF/lib

Issue: theme resources come through Application servlet FIX: You cannot anymore map /* URL

<servlet-mapping>

<servlet-name>workhours</servlet-name> <url-pattern>/*</url-pattern>

</servlet-mapping>

Use stricter URL match (not *), or make sure resources at /ITMILL do not go through any servlet

Issue: "Theme resources are no longer working" FIX: Old theme location WebContent?/themes/<themename>, New theme location WebContent?/ITMILL/themes/<themename>, move all files

Issue: "Layout file layouts/login-layout.html is missing. Components will be drawn for debug purposes." FIX: move all custom layouts into WebContent?/ITMILL/themes/<themename>/layouts folder

Issue: "Images on my custom layout are no longer working" FIX: Update all URL's within your custom layouts, old theme URL "themes/mytheme/img/logo.gif", new theme resources "ITMILL/themes/mytheme/img/logo.gif"

Issue: "My custom component / layout is not visible" FIX: AbstractComponent?.setStyle is now deprecated Remove these:

//main.setStyle("main-layout");

Replace with:

main = new CustomLayout?("main-layout"); w.setLayout(main);

[Jani Laakso]

Olemme tähän mennessä selvinneet ilman yhtään ulkoista dependencyä. Pääsisimmekös tästäkin eroon?

Koska on hyvin mahdollista että tuo tulee conflictaamaan jonkin toisen tulevan commons-fileupload version kanssa, niin en pitäisi ollenkaan huonona seuraavaa vaihtoehtoa - Kopioi suoraan fileupload sorsat osaksi projektiamme - Refactoroi ne pakettiin: com.itmill.toolkit.external.org.apache...

=> Dependency katoaa => Ei voi conflictata => Jarrimme kasvaa hiukan, mutta onko sillä niin väliä

- Joonas

[Jani Laakso]

Issue: theme resources come through Application servlet FIX: You cannot anymore map /* URL

<servlet-mapping>

<servlet-name>workhours</servlet-name> <url-pattern>/*</url-pattern>

</servlet-mapping>

Use stricter URL match (not *), or make sure resources at /ITMILL do not go through any servlet

Tämä on todellinen ongelma. /* matcheri on välttämätön jotta ikkunat, UIDL, URIHandlerit, yms ... voisivat toimia.

=> Ratkaisuna voisi olla että Servlet tarkistaa onko URI "ITMILL/*" ja fallbackkaa defaulttikäsittelijään (en tiedä miten tämä tehdään) tai sitten (huonompi vaihtoehto) web.xml:n kirjoitetaan /ITMILL/* matcheri.

- Joonas

[Joonas Lehtinen]

Reviewed the ticket:

* Issue: "Blank screen on startup with Browser, client-side code is missing." FIX: WebContent??/ITMILL needes to be copied manually (or generate through GWTCompiler)

Created #1042 and #1044

* Issue: "class not found exception on startup, servlet-class has changed." FIX: web.xml needs to be updated because servlet-class has changed, use <servlet-class>com.itmill.toolkit.terminal.gwt.server.ApplicationServlet??</servlet-class>

Created #1043

* Issue: fileupload jar is missing javax.servlet.ServletException??: java.lang.NoClassDefFoundError??: org/apache/commons/fileupload/servlet/ServletFileUpload

Created #1048

* Issue: "Theme resources are no longer working" FIX: Old theme location WebContent??/themes/<themename>, New theme location WebContent? /ITMILL/themes/<themename>, move all files

Fixed in [2609]

* Issue: "Layout file layouts/login-layout.html is missing. Components will be drawn for debug purposes." FIX: move all custom layouts into WebContent??/ITMILL/themes/<themename>/layouts folder * Issue: "Images on my custom layout are no longer working" FIX: Update all URL's within your custom layouts, old theme URL "themes/mytheme/img/logo.gif", new theme resources "ITMILL/themes/mytheme/img/logo.gif"

Wontfix (these two can not be done automaticly????)

* Issue: "My custom component / layout is not visible" FIX: AbstractComponent??.setStyle is now deprecated Remove these:

Fixed in [2614]