Changeset 5254

Timestamp:

08/25/08 09:21:00 (3 months ago)

Author:

marc.englund@…

Message:

Fixes #2005 (server-side scrolling of table broken)

Files:

• trunk/src/com/itmill/toolkit/terminal/gwt/client/ui/IScrollTable.java (modified) (4 diffs)

trunk/src/com/itmill/toolkit/terminal/gwt/client/ui/IScrollTable.java

@@ -75 +75 @@
     private int firstRowInViewPort = 0;
     private int pageLength = 15;
+    private int lastRequestedFirstvisible = 0; // to detect "serverside scroll"
 
     private boolean showRowHeaders = false;
@@ -170 +171 @@
         firstvisible = uidl.hasVariable("firstvisible") ? uidl
                 .getIntVariable("firstvisible") : 0;
+        if (firstvisible != lastRequestedFirstvisible) {
+            // received 'surprising' firstvisible from server: scroll there
+            firstRowInViewPort = firstvisible;
+            bodyContainer
+                    .setScrollPosition(firstvisible * tBody.getRowHeight());
+        }
 
         showRowHeaders = uidl.getBooleanAttribute("rowheaders");
@@ -700 +707 @@
 
         if (postLimit <= lastRendered && preLimit >= firstRendered) {
+            // remember which firstvisible we requested, in case the server has
+            // a differing opinion
+            lastRequestedFirstvisible = firstRowInViewPort;
             client.updateVariable(paintableId, "firstvisible",
                     firstRowInViewPort, false);
@@ -853 +863 @@
             client.updateVariable(paintableId, "lastToBeRendered",
                     lastToBeRendered, false);
-
+            // remember which firstvisible we requested, in case the server has
+            // a differing opinion
+            lastRequestedFirstvisible = firstRowInViewPort;
             client.updateVariable(paintableId, "firstvisible",
                     firstRowInViewPort, false);