Changeset 4978

Timestamp:

06/30/08 12:17:25 (5 months ago)

Author:

joonas.lehtinen@…

Message:

Fixes #1837 : Window dragging (move and resize) bug in Mac Firefox 3

Files:

• trunk/src/com/itmill/toolkit/terminal/gwt/client/ui/IWindow.java (modified) (2 diffs)

trunk/src/com/itmill/toolkit/terminal/gwt/client/ui/IWindow.java

@@ -21 +21 @@
 import com.google.gwt.user.client.ui.Widget;
 import com.itmill.toolkit.terminal.gwt.client.ApplicationConnection;
+import com.itmill.toolkit.terminal.gwt.client.BrowserInfo;
 import com.itmill.toolkit.terminal.gwt.client.Paintable;
 import com.itmill.toolkit.terminal.gwt.client.UIDL;
@@ -360 +361 @@
 
         setFF2CaretFixEnabled(true);
-
-    }
-
-    private void setFF2CaretFixEnabled(boolean enable) {
-        // "missing cursor" browser bug workaround for FF2 in Windows andLinux
-        if (!Util.isFF2()) {
-            return;
-        }
-        if (enable) {
+        fixFF3OverflowBug();
+    }
+
+    /** Disable overflow auto with FF3 to fix #1837. */
+    private void fixFF3OverflowBug() {
+        if (BrowserInfo.get().isFF3()) {
             DeferredCommand.addCommand(new Command() {
                 public void execute() {
-                    String overflow = DOM.getStyleAttribute(getElement(),
-                            "overflow");
-                    DOM.setStyleAttribute(getElement(), "overflow", "auto");
+                    DOM.setStyleAttribute(getElement(), "overflow", "");
                 }
-
             });
-        } else {
-            DOM.setStyleAttribute(getElement(), "overflow", "");
-        }
-
+        }
+    }
+
+    /**
+     * Fix "missing cursor" browser bug workaround for FF2 in Windows and Linux.
+     * 
+     * Calling this method has no effect on other browsers than the ones based
+     * on Gecko 1.8
+     * 
+     * @param enable
+     */
+    private void setFF2CaretFixEnabled(boolean enable) {
+        if (BrowserInfo.get().isFF2()) {
+            if (enable) {
+                DeferredCommand.addCommand(new Command() {
+                    public void execute() {
+                        DOM.setStyleAttribute(getElement(), "overflow", "auto");
+                    }
+                });
+            } else {
+                DOM.setStyleAttribute(getElement(), "overflow", "");
+            }
+        }
     }