Changeset 4911

Timestamp:

06/18/08 07:46:45 (5 months ago)

Author:

marc.englund@…

Message:

Initial commit for #1739, implements Table.addGeneratedColumn()

Files:

• trunk/src/com/itmill/toolkit/ui/Table.java (modified) (14 diffs)

trunk/src/com/itmill/toolkit/ui/Table.java

@@ -181 +181 @@
 
     /**
+     * Holds column generators
+     */
+    private final HashMap columnGenerators = new HashMap();
+
+    /**
      * Holds value of property pageLength. 0 disables paging.
      */
@@ -320 +325 @@
 
     /**
-     * Gets the array of visible column property id:s.
+     * Gets the array of visible column id:s, including generated columns.
      * 
      * <p>
@@ -326 +331 @@
      * </p>
      * 
-     * @return the Value of property availableColumns.
+     * @return an array of currently visible propertyIds and generated column
+     *         ids.
      */
     public Object[] getVisibleColumns() {
@@ -358 +364 @@
         for (int i = 0; i < visibleColumns.length; i++) {
             if (visibleColumns[i] == null) {
-                throw new NullPointerException("Properties must be non-nulls");
-            } else if (!properties.contains(visibleColumns[i])) {
+                throw new NullPointerException("Ids must be non-nulls");
+            } else if (!properties.contains(visibleColumns[i])
+                    && !columnGenerators.containsKey(visibleColumns[i])) {
                 throw new IllegalArgumentException(
-                        "Properties must exist in the Container, missing property: "
+                        "Ids must exist in the Container or as a generated column , missing id: "
                                 + visibleColumns[i]);
             }
         }
 
-        // If this is called befor the constructor is finished, it might be
+        // If this is called before the constructor is finished, it might be
         // uninitialized
         final LinkedList newVC = new LinkedList();
@@ -375 +382 @@
         // Removes alignments, icons and headers from hidden columns
         if (this.visibleColumns != null) {
-            for (final Iterator i = this.visibleColumns.iterator(); i.hasNext();) {
-                final Object col = i.next();
-                if (!newVC.contains(col)) {
-                    setColumnHeader(col, null);
-                    setColumnAlignment(col, null);
-                    setColumnIcon(col, null);
-                }
+            disableContentRefreshing();
+            try {
+                for (final Iterator i = this.visibleColumns.iterator(); i
+                        .hasNext();) {
+                    final Object col = i.next();
+                    if (!newVC.contains(col)) {
+                        setColumnHeader(col, null);
+                        setColumnAlignment(col, null);
+                        setColumnIcon(col, null);
+                    }
+                }
+            } finally {
+                enableContentRefreshing(false);
             }
         }
@@ -1200 +1213 @@
             final boolean[] iscomponent = new boolean[cols];
             for (int i = 0; i < cols; i++) {
-                iscomponent[i] = Component.class
-                        .isAssignableFrom(getType(colids[i]));
+                iscomponent[i] = columnGenerators.containsKey(colids[i])
+                        || Component.class.isAssignableFrom(getType(colids[i]));
             }
             int firstIndexNotInCache;
@@ -1230 +1243 @@
                 if (cols > 0) {
                     for (int j = 0; j < cols; j++) {
-                        final Property p = getContainerProperty(id, colids[j]);
-                        Object value = null;
+                        Property p = null;
+                        Object value = "";
+                        boolean isGenerated = columnGenerators
+                                .containsKey(colids[j]);
+
+                        if (!isGenerated) {
+                            p = getContainerProperty(id, colids[j]);
+                        }
+
                         // check in current pageBuffer already has row
                         int index = firstIndex + i;
-                        if (p != null) {
+                        if (p != null || isGenerated) {
                             if (p instanceof Property.ValueChangeNotifier) {
                                 if (oldListenedProperties == null
@@ -1252 +1272 @@
                                 value = pageBuffer[CELL_FIRSTCOL + j][indexInOldBuffer];
                             } else {
-
-                                if (iscomponent[j]) {
+                                if (isGenerated) {
+                                    ColumnGenerator cg = (ColumnGenerator) columnGenerators
+                                            .get(colids[j]);
+                                    value = cg
+                                            .generateCell(this, id, colids[j]);
+
+                                } else if (iscomponent[j]) {
                                     value = p.getValue();
                                 } else if (p != null) {
@@ -1262 +1287 @@
                                 }
                             }
-                        } else {
-                            value = "";
                         }
 
@@ -1471 +1494 @@
             collapsedColumns.clear();
         }
-        setVisibleColumns(getContainerPropertyIds().toArray());
+
+        // columnGenerators 'override' properties, don't add the same id twice
+        Collection col = new LinkedList();
+        for (Iterator it = getContainerPropertyIds().iterator(); it.hasNext();) {
+            Object id = it.next();
+            if (columnGenerators == null || !columnGenerators.containsKey(id)) {
+                col.add(id);
+            }
+        }
+        // generators added last
+        if (columnGenerators != null && columnGenerators.size() > 0) {
+            col.addAll(columnGenerators.keySet());
+        }
+
+        setVisibleColumns(col.toArray());
 
         // null value as we may not be sure that currently selected identifier
@@ -1478 +1515 @@
 
         // Assure visual refresh
+        resetPageBuffer();
         refreshRenderedCells();
     }
@@ -1740 +1778 @@
                 && iscomponentIndex < iscomponent.length;) {
             final Object columnId = it.next();
-            final Class colType = getType(columnId);
-            iscomponent[iscomponentIndex++] = colType != null
-                    && Component.class.isAssignableFrom(colType);
+            if (columnGenerators.containsKey(columnId)) {
+                iscomponent[iscomponentIndex++] = true;
+            } else {
+                final Class colType = getType(columnId);
+                iscomponent[iscomponentIndex++] = colType != null
+                        && Component.class.isAssignableFrom(colType);
+            }
         }
         target.startTag("rows");
@@ -2236 +2278 @@
 
     /**
+     * Adds a generated column to the Table.
+     * <p>
+     * A generated column is a column that exists only in the Table, not as a
+     * property in the underlying Container. It shows up just as a regular
+     * column.
+     * </p>
+     * <p>
+     * A generated column will override a property with the same id, so that the
+     * generated column is shown instead of the column representing the
+     * property. Note that getContainerProperty() will still get the real
+     * property.
+     * </p>
+     * <p>
+     * Also note that getVisibleColumns() will return the generated columns,
+     * while getContainerPropertyIds() will not.
+     * </p>
+     * 
+     * @param id
+     *                the id of the column to be added
+     * @param generatedColumn
+     *                the {@link ColumnGenerator} to use for this column
+     */
+    public void addGeneratedColumn(Object id, ColumnGenerator generatedColumn) {
+        if (generatedColumn == null) {
+            throw new IllegalArgumentException(
+                    "Can not add null as a GeneratedColumn");
+        }
+        if (columnGenerators.containsKey(id)) {
+            throw new IllegalArgumentException(
+                    "Can not add the same GeneratedColumn twice, id:" + id);
+        } else {
+            columnGenerators.put(id, generatedColumn);
+            visibleColumns.add(id);
+            resetPageBuffer();
+            refreshRenderedCells();
+        }
+    }
+
+    /**
+     * Removes a generated column previously added with addGeneratedColumn.
+     * 
+     * @param id
+     *                id of the generated column to remove
+     * @return true if the column could be removed (existed in the Table)
+     */
+    public boolean removeGeneratedColumn(Object id) {
+        if (columnGenerators.containsKey(id)) {
+            columnGenerators.remove(id);
+            if (!items.containsId(id)) {
+                visibleColumns.remove(id);
+            }
+            resetPageBuffer();
+            refreshRenderedCells();
+            return true;
+        } else {
+            return false;
+        }
+    }
+
+    /**
      * Returns the list of items on the current page
      * 
@@ -2653 +2755 @@
     }
 
+    /**
+     * Used to create "generated columns"; columns that exist only in the Table,
+     * not in the underlying Container. Implement this interface and pass it to
+     * Table.addGeneratedColumn along with an id for the column to be generated.
+     * 
+     */
+    public interface ColumnGenerator {
+
+        /**
+         * Called by Table when a cell in a generated column needs to be
+         * generated.
+         * 
+         * @param source
+         *                the source Table
+         * @param itemId
+         *                the itemId (aka rowId) for the of the cell to be
+         *                generated
+         * @param columnId
+         *                the id for the generated column (as specified in
+         *                addGeneratedColumn)
+         * @return
+         */
+        public abstract Component generateCell(Table source, Object itemId,
+                Object columnId);
+    }
 }