Changeset 4800

Timestamp:

06/09/08 07:26:09 (4 months ago)

Author:

magi@…

Message:

Merged [4773] from trunk to 5.2 branch: Removes FF2 caret fix while moving/resizing, making it much faster; fixes #1751 (Window move 'tearing' (regression))

Files:

• branches/5.2/src/com/itmill/toolkit/terminal/gwt/client/ui/IWindow.java (modified) (4 diffs)

branches/5.2/src/com/itmill/toolkit/terminal/gwt/client/ui/IWindow.java

@@ -357 +357 @@
         }
         super.show();
-        if (Util.isFF2()) {
-            // "missing cursor" browser bug workaround for FF2 in Windows and
-            // Linux
+
+        setFF2CaretFixEnabled(true);
+
+    }
+
+    private void setFF2CaretFixEnabled(boolean enable) {
+        // "missing cursor" browser bug workaround for FF2 in Windows andLinux
+        if (!Util.isFF2()) {
+            return;
+        }
+        if (enable) {
             DeferredCommand.addCommand(new Command() {
                 public void execute() {
@@ -366 +374 @@
                     DOM.setStyleAttribute(getElement(), "overflow", "auto");
                 }
+
             });
-        }
+        } else {
+            DOM.setStyleAttribute(getElement(), "overflow", "");
+        }
+
     }
 
@@ -425 +437 @@
     private void showDraggingCurtain(boolean show) {
         if (show && draggingCurtain == null) {
-            ApplicationConnection.getConsole().log("SHOW");
+
+            setFF2CaretFixEnabled(false); // makes FF2 slow
+
             draggingCurtain = DOM.createDiv();
             DOM.setStyleAttribute(draggingCurtain, "position", "absolute");
@@ -437 +451 @@
             DOM.appendChild(RootPanel.getBodyElement(), draggingCurtain);
         } else if (!show && draggingCurtain != null) {
-            ApplicationConnection.getConsole().log("HIDE");
+
+            setFF2CaretFixEnabled(true); // makes FF2 slow
+
             DOM.removeChild(RootPanel.getBodyElement(), draggingCurtain);
             draggingCurtain = null;